feature/permissions-middleware #147

Merged
dernst merged 17 commits from feature/permissions-middleware into develop 2026-10-30 13:35:53 +00:00
Member
No description provided.
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
fix: Adding missing [Authorize] in some endpoint
All checks were successful
VPS Deploy / build-and-push (pull_request) Successful in 18s
VPS Deploy / deploy (pull_request) Successful in 24s
1c566a88a1
Signed-off-by: Devanoux <ernst.devan@gmail.com>
@ -5,3 +6,3 @@
namespace KeepGrouped.API.Roles;
public sealed class CreateRoleQuery(KeepGroupedDb db): IHandler
public sealed class CreateRoleQuery(KeepGroupedDb db) : IHandler
Owner

Command pas Query

Command pas Query
dernst marked this conversation as resolved
@ -19,0 +23,4 @@
return RoleProblems.RankingTooLow();
}
if (db_role.Name == "Member")
Owner

Transformer member en static const dans Role
et pour le suepr role aussi

Transformer member en static const dans Role et pour le suepr role aussi
dernst marked this conversation as resolved
@ -21,0 +36,4 @@
{
rl.Ranking--;
await db.SaveChangesAsync();
}
Owner

Changer en list_change.foreach ET SURTOUT ne pas appeler savechanges a chaque item, appeler une seule fois a la fin

Changer en list_change.foreach ET SURTOUT ne pas appeler savechanges a chaque item, appeler une seule fois a la fin
dernst marked this conversation as resolved
@ -18,2 +18,3 @@
}
role.Permission = perm;
if (tk.User.Role.Ranking >= db_role.Ranking || ((int)tk.User.Role.Permission & Math.Abs(perm)) == 0)
Owner

faire des operations binaires

faire des operations binaires
dernst marked this conversation as resolved
@ -0,0 +16,4 @@
return RoleProblems.OpNotFound(direction);
}
var op = direction == "up" ? -1 : +1;
Owner

Un role qui ne devrait pas le pouvoir peut se up a l'infini

Un role qui ne devrait pas le pouvoir peut se up a l'infini
dernst marked this conversation as resolved
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
Signed-off-by: Devanoux <ernst.devan@gmail.com>
fix: Check current role ranking > role u want to u
All checks were successful
VPS Deploy / build-and-push (pull_request) Successful in 19s
VPS Deploy / deploy (pull_request) Successful in 23s
7bbf27b1b2
Signed-off-by: Devanoux <ernst.devan@gmail.com>
fix: second verif for the second_role
All checks were successful
VPS Deploy / build-and-push (pull_request) Successful in 18s
VPS Deploy / deploy (pull_request) Successful in 22s
41a27c837e
Signed-off-by: Devanoux <ernst.devan@gmail.com>
asventi approved these changes 2026-10-30 13:23:33 +00:00
@ -8,3 +10,3 @@
public static void MapLogoutUser(this IEndpointRouteBuilder auth)
{
auth.MapDelete("/logout/{id}", [Authorize] async (LogoutQuery query, HttpContext http, string id) =>
auth.MapDelete("/logout/{id}", [Authorize][Roles(Perms.HandleUsers)] async (LogoutQuery query, HttpContext http, string id) =>
Owner

check le ranking des roles

check le ranking des roles
dernst force-pushed feature/permissions-middleware from 41a27c837e
All checks were successful
VPS Deploy / build-and-push (pull_request) Successful in 18s
VPS Deploy / deploy (pull_request) Successful in 22s
to 3778f38fba
All checks were successful
VPS Deploy / build-and-push (pull_request) Successful in 18s
VPS Deploy / deploy (pull_request) Successful in 26s
2026-10-30 13:35:42 +00:00
Compare
dernst merged commit 2b3423cf9d into develop 2026-10-30 13:35:53 +00:00
dernst deleted branch feature/permissions-middleware 2026-10-30 13:35:54 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Transcendence/backend!147
No description provided.